Shared: Generalize the number of columns in a generated MaD row#18612
Merged
paldepind merged 3 commits intogithub:mainfrom Jan 29, 2025
Merged
Shared: Generalize the number of columns in a generated MaD row#18612paldepind merged 3 commits intogithub:mainfrom
paldepind merged 3 commits intogithub:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
paldepind
force-pushed
the
shared-model-generation-row
branch
from
598d4ec to
13e0829
Compare
paldepind
commented
Jan 28, 2025
aschackmull
previously approved these changes
Jan 29, 2025
Contributor
michaelnebel
left a comment
michaelnebel
left a comment
There was a problem hiding this comment.
Very nice approach!
| or | ||
| i = 4 and ExternalFlow::partialModel(api, _, _, _, _, result) // parameters | ||
| or | ||
| i = 5 and result = "" and exists(api) // ext |
Contributor
There was a problem hiding this comment.
So replacing the conjunction with disjuncts (and index) and a subsequent concat works because the values in each column is a function of the api (just an observation and not anything that requires action).
Contributor
There was a problem hiding this comment.
maybe use strictconcat instead.
Contributor
Author
There was a problem hiding this comment.
Makes sense, there should always be at least one column.
Contributor
There was a problem hiding this comment.
same comment as above.
hvitved
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
partialModelpredicate inModelGeneratorInputSigrequires exactly 5 columns to specify each target for a model. In Rust we only need 2 columns to identify a function. This PR generalizes thepartialModelto apartialModelRowwhere any number of columns is supported.